Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Fix teardown of bootdisk tests with request.addfinalizer #14710

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[6.15.z] Fix teardown of bootdisk tests with request.addfinalizer #14710

merged 1 commit into from
Apr 10, 2024

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #14701

Problem Statement

If first test for rhel7 fails, rhel8 and rhel9 fails as well with error as media path is already taken

Solution

Use request.addfinalizer for teardown to delete media and hosts in bootdisk tests

Related Issues

@Gauravtalreja1 @web-flow
Fix teardown of bootdisk tests with request.addfinalizer (#14701)
2d74771 
Signed-off-by: Gaurav Talreja <[email protected]>
(cherry picked from commit a13c05d)
@Satellite-QE Satellite-QE requested a review from a team as a code owner April 10, 2024 08:40
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Apr 10, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_bootdisk.py

@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 6409
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_bootdisk.py --external-logging
Test Result : ================== 3 passed, 68 warnings in 915.83s (0:15:15) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 10, 2024
@Gauravtalreja1 Gauravtalreja1 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Apr 10, 2024
@Satellite-QE Satellite-QE merged commit bac77e7 into 6.15.z Apr 10, 2024
17 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.15.z-a13c05ddb8ce76c7440a24a2d20871e66b76645f branch April 10, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @Gauravtalreja1